use QBImagePicker cocoa pod for iOS #172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…ly work as previous implementation
…tions, equalize class names, fix ios aspect ratio in core modules versions smaller than 4
tbozhikov
force-pushed
the
tbozhikov/cleanup-image-picker
branch
from
cbce111 to
d109a89
Compare
DimitarTachev
approved these changes
Apr 10, 2018
demo/app/main-view-model.ts
Outdated
|
|
||
| // set the images to be loaded from the assets with optimal sizes (optimize memory usage) | ||
| selection.forEach(element => { | ||
| element.options.width = this.isSingleMode ? 300 : 80; |
There was a problem hiding this comment.
Looks like magic numbers. Reuse the same variable with the ImageView size in order to make the connection more visible.
demo/package.json
Outdated
| } | ||
| }, | ||
| "dependencies": { | ||
| "nativescript-imagepicker": "../src", | ||
| "nativescript-theme-core": "^1.0.4", | ||
| "nativescript-unit-test-runner": "^0.3.4", | ||
| "tns-core-modules": "^3.4.0" | ||
| "tns-core-modules": "^4.0.0-2018-03-27-02" |
There was a problem hiding this comment.
replace with 4.0.0 as we will merge it after the official release
…preview sizes with binding in the UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.