Kddimitrov/fix add framework #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Fatme
reviewed
Apr 10, 2019
| file.fileRef = key; | ||
| } else { | ||
| this.addToPbxFileReferenceSection(file); // PBXFileReference | ||
| this.addToFrameworksPbxGroup(file); // PBXGroup |
There was a problem hiding this comment.
Maybe we need this as well
this.addToPbxBuildFileSection(file);
There was a problem hiding this comment.
I don't think we need to do that if we won't add it to the FrameworksBuildPhase.
Fatme
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation adding same SDK framework to two different targets, would result in only one target with the framework. The other one would have been skipped.
Now we check on every level of adding the framework (adding file reference, adding to source build phase, adding to copy files phase - embed) if we are going to create duplicates and if not we add the record.
Breaking change: If framework was already added we will return the existing PBXBuildFile reference instead of false.