Skip to content

Kddimitrov/ns changes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 18, 2019
Merged

Kddimitrov/ns changes #1

merged 16 commits into from
Mar 18, 2019

Conversation

KristianDD
Copy link

Transfer changes from deprecated fork - https://github.com/NativeScript/node-xcode.

Fatme Havaluova and others added 16 commits January 25, 2019 14:21
Those properties should be surrounded by quotation marks based on appearance of special characters in path and basename properties respectively.
They are independent of one another.
*support for c++ files added
*recursively add pbxGroup and its children
*recursively remove pbxGroup and its children
*make sure pbx group name is not duplicated on adding new group
They were wrongly being added to Resources.
@cla-bot
Copy link

cla-bot bot commented Mar 18, 2019

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Kristian D. Dimitrov.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@KristianDD KristianDD merged commit ccab065 into master Mar 18, 2019
@KristianDD KristianDD deleted the kddimitrov/ns-changes branch March 18, 2019 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants