This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: handle relative requests from inside an external module #918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
reviewed
May 31, 2019
| } | ||
|
|
||
| if (externalRegexps.some(regExp => regExp.test(nonRelativeRequest))) { | ||
| return callback(null, 'commonjs ' + request); |
There was a problem hiding this comment.
Check if here you shouldn't use nonRelativeRequest.
KristianDD
approved these changes
May 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The Webpack externals logic is matching only the request (the string inside a require or import call), while we need to match both the request and the context when matching relative requests from inside an external module.
What is the new behavior?
We provide a custom externals handler in order to join the context and the request in such cases.
Related to: NativeScript/nativescript-cli#4658