Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: support platform specific files that are not directly imported anywhere in the app #843

Merged
merged 2 commits into from
Apr 1, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

If you make your entry point (main.ts) a platform-specific file (main.ios.ts and main.android.ts), the webpack compilation will fail. The compilation also fails when the entry point of a linked plugin is a platform-specific file (take a look at the related issue).

What is the new behavior?

The platform-specific files are supported entry points of your app and the linked plugins.

Related to: #612

@ghost ghost assigned DimitarTachev Mar 28, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 28, 2019
@ghost ghost added new PR review and removed cla: yes labels Mar 28, 2019
@DimitarTachev DimitarTachev force-pushed the tachev/fix-platform-files-ng branch from b1861dd to e7ee76e Compare March 28, 2019 15:18
@cla-bot cla-bot bot added the cla: yes label Mar 28, 2019
…nywhere in the app (e.g. when main.ts is platform specific).
@DimitarTachev DimitarTachev force-pushed the tachev/fix-platform-files-ng branch from e7ee76e to fe4ffd9 Compare March 29, 2019 13:41
@rynop
Copy link

rynop commented May 9, 2019

Hi @DimitarTachev - do you have a rough idea when v0.22.0 will be released to NPM? There is another OSS lib that Robert and I are working on that depend on it (ref'd above). Thanks for all your work on this lib.

@DimitarTachev
Copy link
Contributor Author

DimitarTachev commented May 9, 2019

Hi @rynop, the development for 0.22.0 is already frozen, if we don't find blocking issues in our testing phase, you can expect the rc release till the end of the day and an official 0.22.0 release till the end of the next week. Meanwhile, you can access this fix using our next tag (nativescript-dev-webpack@next).

P.S. The 0.22.0 release is synchronized with NativeScript 5.4.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants