This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
fix: support platform specific files that are not directly imported anywhere in the app #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fatme
reviewed
Mar 28, 2019
b1861dd
to
e7ee76e
Compare
…nywhere in the app (e.g. when main.ts is platform specific).
e7ee76e
to
fe4ffd9
Compare
Fatme
approved these changes
Mar 29, 2019
sis0k0
reviewed
Apr 1, 2019
sis0k0
reviewed
Apr 1, 2019
sis0k0
approved these changes
Apr 1, 2019
3 tasks
18be9f0
to
ba1e4c5
Compare
Hi @DimitarTachev - do you have a rough idea when |
Hi @rynop, the development for P.S. The |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
If you make your entry point (main.ts) a platform-specific file (main.ios.ts and main.android.ts), the webpack compilation will fail. The compilation also fails when the entry point of a linked plugin is a platform-specific file (take a look at the related issue).
What is the new behavior?
The platform-specific files are supported entry points of your app and the linked plugins.
Related to: #612