Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

chore(ns-support-hmr-ng transformer): support app options variable #790

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

A runtime exception is thrown when you bootstrap your Angular app using a variable as App options like:
const appOptions = { bootInExistingPage: true }; platformNativeScriptDynamic(appOptions).bootstrapModule(AppModule);

What is the new behavior?

The case is properly handled and covered by an unit test.

@DimitarTachev DimitarTachev merged commit 1385d7a into master Feb 6, 2019
@DimitarTachev DimitarTachev deleted the tachev/support-ng-hmr-app-variable branch February 6, 2019 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants