Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: optimize platform specific files resolver #782

Merged
merged 4 commits into from
Jan 30, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions host/resolver.ts
Original file line number Diff line number Diff line change
@@ -1,23 +1,42 @@
import {
parse,
join,
} from "path";
import { parse, join } from "path";
import { statSync } from "fs";

export function getResolver(platforms: string[]) {
return function(path: string) {
export function getResolver(platforms: string[], explicitResolve: string[] = []) {
const platformSpecificExt = [".ts", ".js", ".scss", ".less", ".css", ".html", ".xml", ".vue", ".json"];
const nsPackageFilters = [
'nativescript',
'tns',
'ns'
];

return function (path: string) {
const nmIndex = path.lastIndexOf('node_modules');

if (nmIndex !== -1) {
const subPath = path.substr(nmIndex + 'node_modules'.length).replace(/\\/g, '/');
const shouldResolve = explicitResolve.length && explicitResolve.some(packageName => subPath.indexOf(packageName) !== -1);
const pathParts = subPath.split(/[/\-_]/);

if (!shouldResolve && pathParts.every(p => nsPackageFilters.every(f => f !== p))) {
return path;
}
}

const { dir, name, ext } = parse(path);

if (platformSpecificExt.indexOf(ext) === -1) {
return path;
}

for (const platform of platforms) {
const platformFileName = `${name}.${platform}${ext}`;
const platformPath = toSystemPath(join(dir, platformFileName));

try {
const stat = statSync(platformPath);
if (stat && stat.isFile()) {
if (statSync(platformPath)) {
return platformPath;
}
} catch(_e) {
} catch (_e) {
// continue checking the other platforms
}
}
Expand All @@ -34,6 +53,6 @@ function toSystemPath(path: string) {

const drive = path.match(/^\\(\w)\\(.*)$/);
return drive ?
`${drive[1]}:\\${drive[2]}`:
`${drive[1]}:\\${drive[2]}` :
path;
}