Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix(Vue): disable mangling of function names when building in production mode #743

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Conversation

academici
Copy link
Contributor

@academici academici commented Dec 17, 2018

PR Checklist

What is the current behavior?

When building {N} Vue apps in production mode the function names are renamed by UglifyJS to make the bundle smaller.
This causes problems when some tns-core-modules components are renamed (SegmentedBar, FormattedString).

tns run ios --bundle --env.production

What is the new behavior?

The function names are not renamed anymore.

fixes nativescript-vue/vue-cli-template#105 for the {N} CLI Vue template.

@academici academici changed the title Fix issue https://github.com/nativescript-vue/vue-cli-template/issues… Fix bug, when using vue in production mode Dec 17, 2018
@sis0k0
Copy link
Contributor

sis0k0 commented Dec 17, 2018

test

@sis0k0
Copy link
Contributor

sis0k0 commented Dec 17, 2018

Hi, @academici! The PR is legitimate. Can you please fill-in the PR template?

@sis0k0 sis0k0 changed the title Fix bug, when using vue in production mode fix(Vue): disable mangling of function names when building in production mode Dec 19, 2018
Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using --env.production breaks SegmentedBar
2 participants