Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Release 0.18.3 #733

Merged
merged 13 commits into from
Dec 10, 2018
Merged

Release 0.18.3 #733

merged 13 commits into from
Dec 10, 2018

Conversation

SvetoslavTsenov
Copy link
Contributor

No description provided.

radeva and others added 13 commits December 1, 2018 06:06
* chore: update community files
* fix: avoid getting `js` template in a `ts` project as we don't have a `typescript` dependency in the templates anymore

* fix: generate tsconfig based on the nativescript-dev-webpack dependency
The context consists of an object with `type` and `module` properties:
- `type` could be `markup`, `script` or `style`
- `module` is the path to the module
* release: cut the 0.18.2 release
* chore: bump version
Remove some files from the npm package as they are meaningful only for development of the plugin.
* fix: project's package.json indentation is not persisted

In case project's package.json uses tabs or multiple spaces for indentation, the postinstall script of nativescript-dev-webpack overwrites it with two spaces whenever it is executed.
The problem is that the plugin tries to modify the package.json and persists it on every operation.
Fix the behavior by checking the indentation character and use it when stringifying the content.
Also compare the current content of the file with the one we will write and skip the write operation in case they match.
Add unit tests for the new methods.

* chore: run unit tests when preparing the package

* fix: getIndentationCharacter is not working when buffer is passed
@SvetoslavTsenov SvetoslavTsenov merged commit 6ca74d0 into release Dec 10, 2018
@SvetoslavTsenov SvetoslavTsenov deleted the release-0.18.3 branch December 10, 2018 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants