This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: send data for fallback if hmr apply fails #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristianDD
force-pushed
the
kddimitrov/hmr-fail-fallback
branch
from
a08f7c0 to
ce65d6a
Compare
KristianDD
commented
Oct 5, 2018
hot.js
Outdated
| } | ||
| }) | ||
| .catch((err) => { | ||
| const status = module.hot.status(); | ||
| if (['abort', 'fail'].indexOf(status) >= 0) { | ||
| log.warn(`Cannot apply update. ${refresh}`); | ||
| log.warn(`Cannot apply update with hmr hash ${currentHash}.`); | ||
| log.warn(err.stack || err.message); | ||
| if (options.reload) { | ||
| window.location.reload(); |
There was a problem hiding this comment.
Can be removed maybe.
KristianDD
commented
Oct 5, 2018
| } | ||
| }) | ||
| .catch((err) => { | ||
| const status = module.hot.status(); | ||
| if (['abort', 'fail'].indexOf(status) >= 0) { | ||
| log.warn(`Cannot apply update. ${refresh}`); | ||
| log.warn(`Cannot apply update with hmr hash ${currentHash}.`); |
There was a problem hiding this comment.
Add comment to not change - it will break CLI
KristianDD
force-pushed
the
kddimitrov/hmr-fail-fallback
branch
from
ce65d6a to
2309498
Compare
sis0k0
reviewed
Oct 9, 2018
| @@ -90,17 +91,16 @@ function check(options) { | |||
| result(modules, appliedModules); | |||
|
|
|||
| if (upToDate()) { | |||
| log.info('App is up to date.'); | |||
| //Do not modify message - CLI depends on this exact content to determine hmr operation status. | |||
| log.info(`Successfully applied update with hmr hash ${currentHash}. App is up to date.`); | |||
There was a problem hiding this comment.
Can you extract the messages to constants?
sis0k0
approved these changes
Oct 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Currently there is no indication in the log, which hmr patch is applied and in hook args there is no data about the hmr hash and the files that should be synced if the hmr operation fails.
What is the new behavior?
There is a hash added for start, success or fail of the hmr operation and there are properties in the
hookArgswhich are populated with information about current hmr operation.Fixes/Implements/Closes #3892.