Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix(JS/TS): use webpack resolver instead of Node.js resolver #681

Merged
merged 6 commits into from
Dec 13, 2018
Merged

fix(JS/TS): use webpack resolver instead of Node.js resolver #681

merged 6 commits into from
Dec 13, 2018

Conversation

ggodlewski
Copy link
Contributor

@ggodlewski ggodlewski commented Sep 29, 2018

PR Checklist

What is the current behavior?

TS files for custom xml components are not budled.

What is the new behavior?

Fixes #627

@sis0k0
Copy link
Contributor

sis0k0 commented Oct 3, 2018

test

Copy link
Contributor

@sis0k0 sis0k0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@radeva
Copy link
Contributor

radeva commented Nov 19, 2018

Hi @ggodlewski ,

Congratulations on being one of the winners in the {N} First-time contributors contest!

You can claim your prize by contacting us at nativescriptwinners[at]progress.com not later than Nov 30th 2018 . Make sure you send us the following info: 
👉Your full name 
👉Your email 
👉Your country or residence 

Best regards,
The NativeScript Team

@ggodlewski
Copy link
Contributor Author

Thanks a lot :)

@sis0k0 I think something went wrong with merging into master? Can you check it?
I'd really appreciate if this issue is fixed in the next release.

@sis0k0 sis0k0 changed the title fix: use webpack resolver in xml-namespace-loader insead of nodejs re… fix(JS/TS): use webpack resolver instead of Node.js resolver Dec 13, 2018
@sis0k0 sis0k0 merged commit 9adc7e7 into NativeScript:master Dec 13, 2018
@sis0k0
Copy link
Contributor

sis0k0 commented Dec 13, 2018

Many thanks for the fix, @ggodlewski! It will be released as part of nativescript-dev-webpack v0.18.4.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants