This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat(xml-namespace-loader): add ignore option #605
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this might be unnecessary, because you can remove the loader from the webpack config. Am I missing something? |
|
If you remove the loader, then you also have to manually register plugins included in the XML files. What I would like is still leave the automatic registration of plugins (which works pretty awesome) and only ignore the local fragments which have issues with the automatic registration. |
sis0k0
approved these changes
Jul 16, 2018
|
test |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
There is no way to exclude local modules. This causes problems with typescript based apps.
What is the new behavior?
With the
ignoreoption user can exclude any local fragments and register them either manually or by using theregisterModulesregex option for thebundle-config-loaderCloses #558.