Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

0.12 messes up fragments #558

Closed
7 tasks done
PeterStaev opened this issue Jun 7, 2018 · 0 comments · Fixed by #618
Closed
7 tasks done

0.12 messes up fragments #558

PeterStaev opened this issue Jun 7, 2018 · 0 comments · Fixed by #618

Comments

@PeterStaev
Copy link
Contributor

Issue Checklist

  • You are submitting: bug report
  • You verified that this is a real problem by searching the [NativeScript Forum] and the other [issues] in this repo.
  • You checked our [demo apps] and the [documentation] for sample usage.

Tell us about the problem

The default register for custom controls is neat, but causes problems with "fragments" that have code behind files. Under fragments I mean files common parts of UI extracted into an XML+TS files. When webpack loader includes those fragments it includes the JS files and not the TS files. So if have not compiled your code it will not load the codebehind. Or even nastier - if you have run normal builds, then run webpack build and make changes to the code it will continue picking up old compiled JS code instead of the new one in the TS file.

The XML loader should exclude any local modules (i.e. fragments) from the load and leave those to be handled by the bundle-config in the app.

Local environment

  • Platform Mac
  • Node version 8 LTS
  • NativeScript CLI version 4.1

Project data

  • Platform you are building the app for Both
sis0k0 pushed a commit that referenced this issue Jul 23, 2018
With the ignore option user can exclude any local fragments and register them either manually or by using the registerModules regex option for the bundle-config-loader

Closes #558.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants