Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat: configure v8Version for snapshot tools #503

Merged
merged 3 commits into from
Apr 25, 2018
Merged

feat: configure v8Version for snapshot tools #503

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0a46180
Read v8 version from webpack.config.js
vtrifonov Apr 23, 2018
5070a00
use options instead of this.options
vtrifonov Apr 23, 2018
1d5458b
Merge branch 'master' into trifonov/v8-version
sis0k0 Apr 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions plugins/NativeScriptSnapshotPlugin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ exports.NativeScriptSnapshotPlugin = (function() {
targetArchs: options.targetArchs,
useLibs: options.useLibs,
androidNdkPath: options.androidNdkPath,
v8Version: options.v8Version,
tnsJavaClassesPath: join(preparedAppRootPath, "tns-java-classes.js")
}).then(() => {
// Make the original file empty
Expand Down
3 changes: 3 additions & 0 deletions plugins/NativeScriptSnapshotPlugin/options.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
},
"useLibs": {
"type": "boolean"
},
"v8Version": {
"type": "string"
}
},
"additionalProperties": false
Expand Down