This repository was archived by the owner on Aug 7, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 40
docs: add PR and ISSUE templates #453
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e493aa6
docs: fix link in contributing guide
sis0k0 fcff61b
docs: add a PR template
sis0k0 d9d1ef2
docs: add an issue template
sis0k0 8186ffe
docs: extract links in ISSUE_TEMPLATE
sis0k0 4d73ae0
docs: add note for adding new tests in PR template
sis0k0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!-- | ||
We, the rest of the NativeScript community, thank you for your | ||
feedback! | ||
To help the rest of the community review your issue, please follow the instructions in the template. | ||
--> | ||
|
||
<!-- ISSUE TEMPLATE --> | ||
<!-- (Update "[ ]" to "[x]" to check a box) --> | ||
|
||
## Issue Checklist | ||
|
||
- [ ] You are submitting: <!-- a feature request; a bug report. For questions, please use the [NativeScript Forum](http://forum.nativescript.org). --> | ||
- [ ] You verified that this is a real problem by searching the [NativeScript Forum](http://forum.nativescript.org) and the | ||
[other issues in this repo](https://github.com/nativescript/nativescript-dev-webpack/issues?utf8=✓&q=is%3Aissue). | ||
|
||
## Tell us about the problem | ||
<!-- Describe the issue with a few words. Provide build log and steps to reproduce if relevant. --> | ||
|
||
## Local environment | ||
|
||
- [ ] Platform <!-- Linux, Mac, Windows --> | ||
- [ ] Node version XX <!-- run `node --version` --> | ||
- [ ] NativeScript CLI version <!-- run `tns --version` --> | ||
|
||
## Project data | ||
|
||
- [ ] Platform you are building the app for <!-- Android, iOS, Both --> | ||
- [ ] Node dependencies: | ||
``` | ||
<!-- Provide the content of your package.json. --> | ||
``` | ||
- [ ] Webpack configuration: | ||
``` | ||
<!-- Provide the content of your webpack.config.js. --> | ||
``` | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
<!-- | ||
We, the rest of the NativeScript community, thank you for your | ||
contribution! | ||
To help the rest of the community review your change, please follow the instructions in the template. | ||
--> | ||
|
||
<!-- PULL REQUEST TEMPLATE --> | ||
<!-- (Update "[ ]" to "[x]" to check a box) --> | ||
|
||
## PR Checklist | ||
|
||
- [ ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages. | ||
- [ ] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it. | ||
- [ ] You have signed the [CLA](http://www.nativescript.org/cla). | ||
- [ ] All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can also add a check "Tests for the changes are included" |
||
## What is the current behavior? | ||
<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. --> | ||
|
||
## What is the new behavior? | ||
<!-- Describe the changes. --> | ||
|
||
Fixes/Implements/Closes #[Issue Number]. | ||
|
||
<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. --> | ||
|
||
<!-- | ||
BREAKING CHANGES: | ||
|
||
|
||
[Describe the impact of the changes here.] | ||
|
||
Migration steps: | ||
[Provide a migration path for existing applications.] | ||
--> | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The forums we use are located in https://discourse.nativescript.org/ . There is a redirect, but still you can change it to this link.