This repository was archived by the owner on Aug 7, 2021. It is now read-only.
refactor: Refactor moduleId: __filename to moduleId: module.id #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PanayotCankov
commented
Dec 11, 2017
moduleid-compat-loader.js
Outdated
| ); | ||
|
|
||
| if (source != noModuleIdsSource) { | ||
| console.log("Before:\n\n" + source + "\n\nAfter:\n\n" + noModuleIdsSource + "\n\n"); |
There was a problem hiding this comment.
Don't. Just don't! :D this console.log is a leftover.
PanayotCankov
force-pushed
the
refactor-module-id
branch
from
c7f2230 to
0930675
Compare
…ment compat loader for webpack The angular 5 framework will typecheck the moduleId is a string, while in webpack scenarios the moduleId is ignored and relative paths are handled by the angular compiler and the webpack loaders, module.id is number and fails the typeschecks. Implemented a loader that will strip the moduleId: module.id when compiled with webpack, the moduleId: module.id is still necessary for development without webpack. As a reminder if we manage to setup webpack for watch and debug, we can recommend removing all moduleId: module.id occurences and delete the loader.
sis0k0
approved these changes
Dec 12, 2017
MartoYankov
approved these changes
Dec 12, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The angular 5 framework will typecheck the moduleId is a string,
while in webpack scenarios the moduleId is ignored and relative paths
are handled by the angular compiler and the webpack loaders,
module.id is number and fails the typeschecks.
Implemented a loader that will strip the moduleId: module.id when
compiled with webpack, the moduleId: module.id is still necessary for development without webpack.
As a reminder if we manage to setup webpack for watch and debug,
we can recommend removing all moduleId: module.id occurences and delete the loader.