This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix(ns-bundle): support for Node.js 9 #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sis0k0
reviewed
Nov 10, 2017
|
|
||
| childProcess.on("close", code => { | ||
| if (code) { | ||
| reject({ | ||
| code, | ||
| message: `child process exited with code ${code}`, | ||
| }); | ||
| } else { | ||
| const versionRegex = /^(?:\d+\.){2}\d+.*?$/m; | ||
| const matches = stdoutData.toString().match(versionRegex); |
There was a problem hiding this comment.
We have a dependency to 'semver'. We can use it instead if the regex.
There was a problem hiding this comment.
The idea here is to get the version from the string. Output of tns --version is:
Support for Node.js 9.0.0 is not verified. This CLI might not install or run properly.
3.3.0
So the regex should find the 3.3.0 version from it.
sis0k0
reviewed
Nov 10, 2017
There was a problem hiding this comment.
Can you make the title follow these https://gist.github.com/stephenparish/9941e89d80e2bc58a153 coding convetions? Something like `fix(ns-bundle): support for NodeJS 9"
sis0k0
approved these changes
Nov 10, 2017
rosen-vladimirov
changed the title
rosen-vladimirov
force-pushed
the
vladimirov/fix-nodejs9-support
branch
from
8c9b70b to
3116e5d
Compare
|
@sis0k0 I've updated the PR title and the commit message |
When you have Node.js 9 installed, CLI prints a warning that support for this version is not verified. Our webpack plugin tries to get the version, but it receives the warning and decides the version is incorrect. So all scripts fail. In order to resolve the issue, get all data send to the stdout of the spawned `tns --version` process and parse it.
sis0k0
force-pushed
the
vladimirov/fix-nodejs9-support
branch
from
3116e5d to
17d52d2
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have Node.js 9 installed, CLI prints a warning that support for this version is not verified. Our webpack plugin tries to get the version, but it receives the warning and decides the version is incorrect. So all scripts fail.
In order to resolve the issue, get all data send to the stdout of the spawned
tns --versionprocess and parse it.