Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix(template): ship bundle with empty tns-java-classes.js chunk #128

Merged
merged 1 commit into from
Apr 25, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions webpack.common.js.angular.template
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,15 @@ module.exports = function (platform, destinationApp) {

var plugins = [
new ExtractTextPlugin("app.css"),
// Vendor libs go to the vendor.js chunk
new webpack.optimize.CommonsChunkPlugin({
name: ["vendor"]
name: [
// Vendor libs go to the vendor.js chunk
"vendor",

// Compatibility workaround with NativeScript 2.5 Android runtime
// https://github.com/NativeScript/NativeScript/issues/3947
"tns-java-classes",
],
}),
// Define useful constants like TNS_WEBPACK
new webpack.DefinePlugin({
Expand Down
9 changes: 8 additions & 1 deletion webpack.common.js.javascript.template
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ module.exports = function (platform, destinationApp) {
new ExtractTextPlugin("app.css"),
// Vendor libs go to the vendor.js chunk
new webpack.optimize.CommonsChunkPlugin({
name: ["vendor"]
name: [
// Vendor libs go to the vendor.js chunk
"vendor",

// Compatibility workaround with NativeScript 2.5 Android runtime
// https://github.com/NativeScript/NativeScript/issues/3947
"tns-java-classes",
],
}),
// Define useful constants like TNS_WEBPACK
new webpack.DefinePlugin({
Expand Down
9 changes: 8 additions & 1 deletion webpack.common.js.typescript.template
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,14 @@ module.exports = function (platform, destinationApp) {
new ExtractTextPlugin("app.css"),
// Vendor libs go to the vendor.js chunk
new webpack.optimize.CommonsChunkPlugin({
name: ["vendor"]
name: [
// Vendor libs go to the vendor.js chunk
"vendor",

// Compatibility workaround with NativeScript 2.5 Android runtime
// https://github.com/NativeScript/NativeScript/issues/3947
"tns-java-classes",
],
}),
// Define useful constants like TNS_WEBPACK
new webpack.DefinePlugin({
Expand Down