This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix(template): ship bundle with empty tns-java-classes.js chunk
#128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for compatibility reasons (NativeScript 2.5). When a non-webpacked NativeScript application is deployed to phone, the apk contains a `tns-java-classes.js` file. If that file is present, it is dynamically loaded by the Android runtime at startup. Webpacked NativeScript applications didn't contain that file as it is not needed. But when the application is deployed to phone, the previous `tns-java-classes.js` file is not removed from the app folder on the phone. That causes the Android runtime to try load the file and fail. Since this commit, all webpacked NativeScript apps will be shipped with an empty `tns-java-classes.js` file which is harmless and is used to override the existing file left from previous deployment. related to NativeScript/NativeScript#3613, NativeScript/NativeScript#3947
vakrilov
approved these changes
Apr 24, 2017
|
run ci |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for compatibility reasons (NativeScript 2.5).
When a non-webpacked NativeScript application is deployed to phone, the apk
contains a
tns-java-classes.jsfile. If that file is present, it isdynamically loaded by the Android runtime at startup.
Webpacked NativeScript applications didn't contain that file as it is
not needed. But when the application is deployed to phone, the previous
tns-java-classes.jsfile is not removed from the app folder on thephone. That causes the Android runtime to try load the file and fail.
Since this commit, all webpacked NativeScript apps will be shipped with
an empty
tns-java-classes.jsfile which is harmless and is used tooverride the existing file left from previous deployment.
related to NativeScript/NativeScript#3613, NativeScript/NativeScript#3947