This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: allow extending webpack.config.js through env #1116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case you need to extend the webpack.config.js, currently you cannot extend everything and you need to write a lot of custom logic. This PR adds the possibility to extend the appComponents, entries and alias through `env`. Also update demo applications to use latest CLI feature for extending webpack.config.js
|
test ngapps |
DimitarTachev
approved these changes
Jan 16, 2020
As the demo apps are now using custom webpack.config.js files, they no longer need the default webpack.config.js files. They'll be managed by the installation of nativescript-dev-webpack
|
test webpack-apps |
1 similar comment
|
test webpack-apps |
|
test webpack-apps branch#vladimirov/custom-configs |
|
@rosen-vladimirov thanks for excellent feature. How I'll add custom file type in |
|
Hey @jibon57 , |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you need to extend the webpack.config.js, currently you cannot extend everything and you need to write a lot of custom logic. This PR adds the possibility to extend the appComponents, entries and alias through
env.Also update demo applications to use latest CLI feature for extending webpack.config.js
Merge after: NativeScript/nativescript-cli#5216
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].