This repository was archived by the owner on Aug 7, 2021. It is now read-only.
feat: stop using the proxy tns-core-modules
package when the @nativescript/core
is available
#1093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
It's not possible to use the plugin without the
tns-core-modules
proxy package because we injecttns-core-modules
require statements in the app.What is the new behavior?
The plugin injects the require statements based on the
@nativescript/core
package availability.P.S. The PR is based on the @DickSmith's proposal in this PR with two additional improvements.
Related to: #1089