Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

feat: stop using the proxy tns-core-modules package when the @nativescript/core is available #1093

Merged
merged 2 commits into from
Nov 21, 2019

Conversation

DimitarTachev
Copy link
Contributor

PR Checklist

What is the current behavior?

It's not possible to use the plugin without the tns-core-modules proxy package because we inject tns-core-modules require statements in the app.

What is the new behavior?

The plugin injects the require statements based on the @nativescript/core package availability.

P.S. The PR is based on the @DickSmith's proposal in this PR with two additional improvements.

  1. The code is meant to be backward compatible (it should work with core modules before 6.2.0.)
  2. The "short imports" syntax is also supported in the "scoped packages only" flow.

Related to: #1089

@cla-bot cla-bot bot added the cla: yes label Nov 8, 2019
@DimitarTachev
Copy link
Contributor Author

test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps

1 similar comment
@rosen-vladimirov
Copy link
Contributor

test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps

@Fatme
Copy link
Contributor

Fatme commented Nov 11, 2019

test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-debug cli-device cli-run

@Fatme
Copy link
Contributor

Fatme commented Nov 11, 2019

test cli-templates cli-preview cli-test cli-vue cli-debug cli-device cli-run

1 similar comment
@Fatme
Copy link
Contributor

Fatme commented Nov 11, 2019

test cli-templates cli-preview cli-test cli-vue cli-debug cli-device cli-run

@Fatme
Copy link
Contributor

Fatme commented Nov 12, 2019

test cli-smoke cli-templates cli-plugin cli-preview cli-tests cli-vue cli-build cli-debug cli-device cli-run webpack-apps

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants