Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: stop ignoring the initial hot updates #1081

Merged
merged 1 commit into from
Oct 30, 2019

Conversation

DimitarTachev
Copy link
Contributor

@DimitarTachev DimitarTachev commented Oct 29, 2019

PR Checklist

What is the current behavior?

The initial app start is not calling the core modules' __onLiveSync method as it expects that the changes are already applied. However, the HMR updates and the app start are asynchronous and when the app starts before the Hot Updates, the core modules are never updated.

What is the new behavior?

We always call the core modules' __onLiveSync in order to ensure that the hot updates will affect the app state.

Related to: NativeScript/worker-loader#41 #1082

@cla-bot cla-bot bot added the cla: yes label Oct 29, 2019
@DimitarTachev DimitarTachev merged commit 203df90 into master Oct 30, 2019
@DimitarTachev DimitarTachev deleted the tachev/fix-initial-hot-updates branch October 30, 2019 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants