This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: stop ignoring the initial hot updates #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
The initial app start is not calling the core modules'
__onLiveSync
method as it expects that the changes are already applied. However, the HMR updates and the app start are asynchronous and when the app starts before the Hot Updates, the core modules are never updated.What is the new behavior?
We always call the core modules'
__onLiveSync
in order to ensure that the hot updates will affect the app state.Related to: NativeScript/worker-loader#41 #1082