Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: stop on compilation error in typescript applications #1078

Merged
merged 1 commit into from
Oct 29, 2019

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Oct 25, 2019

We have a limitation that webpack compilation doesn't stop on error in typescript applications. That was due to the issue in fork-ts-checker-webpack-plugin. After merging the PR that fixes the issue and releasing 2.0.0 version of the plugin, we can update it on our side and that way webpack compilation will stop on syntax/semantic errors within the application.

Rel to: NativeScript/nativescript-cli#3785
Rel to: #1083

PR Checklist

What is the current behavior?

What is the new behavior?

Fixes/Implements/Closes #[Issue Number].

We have a limitation that webpack compilation doesn't stop on error in typescript applications. That was due to the issue in fork-ts-checker-webpack-plugin. After merging [the PR that fixes the issue](TypeStrong/fork-ts-checker-webpack-plugin#337) and releasing 2.0.0 version of the plugin, we can update it on our side and that way webpack compilation will stop on syntax/semantic errors within the application.

Rel to: NativeScript/nativescript-cli#3785
@cla-bot cla-bot bot added the cla: yes label Oct 25, 2019
@Fatme Fatme merged commit 4e9202f into master Oct 29, 2019
@Fatme Fatme added this to the 1.4.0 milestone Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants