feat: support useLibs though env.compileSnapshot and calculate the NDK path internally #1063

DimitarTachev · 2019-10-10T08:48:59Z

PR Checklist

The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
You have signed the [CLA].
All existing tests are passing: https://github.com/NativeScript/nativescript-dev-webpack/blob/master/CONTRIBUTING.md#testing-locally-by-running-e2e-tests
Tests for the changes are included.

…K path internally

androidProjectHelpers.js

DimitarTachev added 2 commits October 9, 2019 17:28

feat: support useLibs though env.compileSnapshot and calculate the ND…

5431bd7

…K path internally

refactor: remove outdated code for not supported Android Runtime 5.1

89f2df3

cla-bot bot added the cla: yes label Oct 10, 2019

Fatme reviewed Oct 10, 2019

View reviewed changes

androidProjectHelpers.js Outdated Show resolved Hide resolved

chore: fix PR comments

b0436cd

DimitarTachev force-pushed the tachev/aab-improvements branch from 0f2c87c to b0436cd Compare October 10, 2019 13:39

Fatme approved these changes Oct 15, 2019

View reviewed changes

DimitarTachev merged commit 2b77549 into master Oct 15, 2019

DimitarTachev deleted the tachev/aab-improvements branch October 15, 2019 12:14