This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix: stop generating snapshot for ia64 for older runtimes #1032
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runtime version is below 6.0.2 we should generate snapshot only for armv7, arm64 and ia32 archs. However, as in the validation schema we have default value for the targetArchs, the logic that should determine if ia64 should be removed from the targetArchs decides the archs are passed by the user and does not strip anything from them. Remove the default values from the JSON Schema - they are calculated in the code, so there's no need to have them on two places. As we can not have our conditional logic in the JSON schema, keep calculation of the default values only in the code.
PR Checklist
What is the current behavior?
When Runtime 6.0.1 is used, snapshots are generated for 4 architectures. The ia64 is invalid.
What is the new behavior?
When Runtime 6.0.1 is used, snapshots are generated for 3 architectures.
Fixes/Implements/Closes #[Issue Number].