Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

fix: stop generating snapshot for ia64 for older runtimes #1032

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

rosen-vladimirov
Copy link
Contributor

When the runtime version is below 6.0.2 we should generate snapshot only for armv7, arm64 and ia32 archs. However, as in the validation schema we have default value for the targetArchs, the logic that should determine if ia64 should be removed from the targetArchs decides the archs are passed by the user and does not strip anything from them. Remove the default values from the JSON Schema - they are calculated in the code, so there's no need to have them on two places. As we can not have our conditional logic in the JSON schema, keep calculation of the default values only in the code.

PR Checklist

What is the current behavior?

When Runtime 6.0.1 is used, snapshots are generated for 4 architectures. The ia64 is invalid.

What is the new behavior?

When Runtime 6.0.1 is used, snapshots are generated for 3 architectures.

Fixes/Implements/Closes #[Issue Number].

When the runtime version is below 6.0.2 we should generate snapshot only for armv7, arm64 and ia32 archs. However, as in the validation schema we have default value for the targetArchs, the logic that should determine if ia64 should be removed from the targetArchs decides the archs are passed by the user and does not strip anything from them. Remove the default values from the JSON Schema - they are calculated in the code, so there's no need to have them on two places. As we can not have our conditional logic in the JSON schema, keep calculation of the default values only in the code.
@rosen-vladimirov rosen-vladimirov added this to the 1.1.1 milestone Aug 21, 2019
@rosen-vladimirov rosen-vladimirov self-assigned this Aug 21, 2019
@cla-bot cla-bot bot added the cla: yes label Aug 21, 2019
@rosen-vladimirov rosen-vladimirov merged commit ca4efe4 into release Aug 21, 2019
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-snapshot-older-runtime branch August 21, 2019 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants