This repository was archived by the owner on Aug 7, 2021. It is now read-only.
fix(hmr): check for hot update should not create new file #1020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the check for hot update creates a new file in case it does not exist (as the method from tns-core-modules is doing this). This is a problem when trying to install `.ipa` on device and the `.ipa` file contains JavaScript files with HMR enabled. This may happen in case you run `tns run ios` on device and after command finishes the execution open the project in Xcode and deploy the app from there or uninstall it from device and install the produced `.ipa` manually. The problem in the mentioned scenarios is that the JavaScript file cannot write files in the directory where the `.ipa` is installed. When `tns run ios` is executed, it livesyncs the files in a different location, so the HMR can create the files there. To fix the issue check if the hmr file exist before reading its content.
DimitarTachev
approved these changes
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the check for hot update creates a new file in case it does not exist (as the method from tns-core-modules is doing this). This is a problem when trying to install
.ipaon device and the.ipafile contains JavaScript files with HMR enabled.This may happen in case you run
tns run ioson device and after command finishes the execution open the project in Xcode and deploy the app from there or uninstall it from device and install the produced.ipamanually. The problem in the mentioned scenarios is that the JavaScript file cannot write files in the directory where the.ipais installed.When
tns run iosis executed, it livesyncs the files in a different location, so the HMR can create the files there.To fix the issue check if the hmr file exist before reading its content.
PR Checklist
What is the current behavior?
What is the new behavior?
Fixes issue #1005