Skip to content
This repository was archived by the owner on Aug 7, 2021. It is now read-only.

App throws when bundling with --uglify and using FadeTransition (for RadSideDrawer) #258

Closed
NickIliev opened this issue Aug 16, 2017 · 8 comments · Fixed by #426
Closed
Labels

Comments

@NickIliev
Copy link
Contributor

NickIliev commented Aug 16, 2017

Steps to reproduce - use this application or follow these steps:

  • create new app with
tns create myApp --template https://github.com/NativeScript/template-drawer-navigation-ng
  • install WebPack
npm install --save-dev nativescript-dev-webpack
npm install
  • bundle with uglify
npm run start-android-bundle --uglify

Result: the application is build succsessfully but then throws the following:

JS: Warning: 't' is not supported when 'showOverNavigation' is set to 'true'.
JS: ERROR RangeError: Maximum call stack size exceeded

Reproducible with both official and next releases of tns-core-modules (official 3.1.1) and nativescript-dev-webpack (official 0.7.3).

reported via t1125353

@NickIliev NickIliev added the bug label Aug 16, 2017
@NickIliev NickIliev changed the title App throws wehn bundling with --uglify and using FadeTransition (for RadSideDrawer) App throws when bundling with --uglify and using FadeTransition (for RadSideDrawer) Aug 16, 2017
@elvismercado
Copy link

i also have this issue with npm run start-ios-bundle --uglify

@ChrAraya
Copy link

ChrAraya commented Sep 7, 2017

same here but also have problem with the CSS in the sidebar.

here some examples:

with tns run ios

captura de pantalla 2017-09-07 a la s 10 22 33

with npm run start-ios-bundle --uglify and npm run start-ios-bundle

captura de pantalla 2017-09-07 a la s 10 20 15

@pako8x
Copy link

pako8x commented Sep 9, 2017

try
npm install -g npm-check-updates
ncu -u
npm install

and then
npm run start-ios-bundle --uglify

It worked for me

@mhadaily
Copy link

mhadaily commented Jan 6, 2018

I have the same issue even with other transition such public sideDrawerTransition: DrawerTransitionBase = new PushTransition();

tns-ios version: 3.4
nativescript-pro-ui version: 3.3.0

thanks, guys.

@felipebueno
Copy link

felipebueno commented Jan 26, 2018

Hi, @charaya!

Did you manage to solve the CSS problem with the sidedrawer? I'm facing the same issue at this moment and I have no clue on how to fix that.

With webpack 👎
drawer_css_with_webpack

Without webpack 👍
drawer_css_without-webpack

@sis0k0
Copy link
Contributor

sis0k0 commented Jan 26, 2018

@felipebueno, can you share your project or some steps to reproduce the issue? The css looks ok if I use the drawer template and build the app with tns run android --bundle --env.uglify.

sis0k0 added a commit that referenced this issue Jan 26, 2018
…amed

This should fix the issue:
```
JS: Warning: 't' is not supported when 'showOverNavigation' is set to 'true'.
```
Should be reverted after 4.0 release. See: ProgressNS/nativescript-ui-feedback#477 (comment)

fixes #258
@felipebueno
Copy link

felipebueno commented Jan 26, 2018

Ok, just a follow up on my previous comment.

As a temporary solution, I moved all the custom styles from the app/shared/my-drawer/_MyDrawer.scss file to the app/_app-common.scss and it works as expected.

@sis0k0 Hmm, I can't share the project (becaus it's not mine) but I'll create a new project using the template-drawer-navigation template and try to reproduce the problem. I'll comment here again as soon as I publish it to a repository so you can take a look.

Thanks, @sis0k0

@felipebueno
Copy link

felipebueno commented Jan 26, 2018

@sis0k0 I managed to get it working :)

I'm not sure what was the problem but here's what I did.

I created a new project with the drawer-navigation template, bundled it with webpack and run it on my device. Everything worked properly, including the drawer's styles.

Then I copied the drawer module from this new project to my main project (that one from the screenshots above) and updated all my pages to use this new app/shared/drawer module instead of the old app/shared/my-drawer. I bundled the app and it woked :)

I have no idea why this worked but I have some guesses. I noticed that the new project I created with the drawer template was different from the one I created three weeks ago which is the one I'm using to build my project on. Maybe they fixed some bugs, I don't know... will look into it another time. Getting back to work now 😄

sis0k0 added a commit that referenced this issue Jan 29, 2018
…amed (#426)

This should fix the issue:
```
JS: Warning: 't' is not supported when 'showOverNavigation' is set to 'true'.
```
Should be reverted after 4.0 release. See: ProgressNS/nativescript-ui-feedback#477 (comment)

fixes #258
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
7 participants