Use moduleResolution classic when --syncAllFiles option is not specified #44
Conversation
There was a problem hiding this comment.
It is important to update the before-watch hook as well. You'll have to modify the call of the hook itself in CLI. You can pass the watchAllFiles option (you have it in the context there) inside the hookArgs and read it in the watch hook.
lib/before-prepare.js
Outdated
| @@ -11,5 +11,6 @@ module.exports = function ($logger, $projectData, $options, hookArgs) { | |||
| } | |||
|
|
|||
| var release = $options.release || appFilesUpdaterOptions.release; | |||
| return compiler.runTypeScriptCompiler($logger, $projectData.projectDir, { release }); | |||
| var syncAllFiles = $options && $options.syncAllFiles; | |||
There was a problem hiding this comment.
this will not work in case the hook is executed from Sidekick (i.e. when CLI is used as a library). In this case the $options values will be the default ones as there's no command line args to populate them. Instead of using $options, you'll have to modify the preparePlatformCore method to receive this value as an argument. For example, we can add skipModulesNativeCheck (as there's already such value in the preparePlatform method) in the appFilesUpdaterOptions object and you can access it here via:
const skipModulesNativeCheck = hookArgs && hookArgs.appFilesUpdaterOptions && hookArgs.appFilesUpdaterOptions.skipModulesNativeCheck;
const syncAllFiles = $options && $options.syncAllFiles || !skipModulesNativeCheck;
Fatme
force-pushed
the
fatme/module-resolution
branch
2 times, most recently
from
56b508c to
9ad93df
Compare
Fatme
force-pushed
the
fatme/module-resolution
branch
from
9ad93df to
3d8d32f
Compare
|
ping @rosen-vladimirov |
|
Should be merged with this PR NativeScript/nativescript-cli#3436 |
Fixes NativeScript/nativescript-cli#3378