docs(readme): update readme & add contributing.md #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mitko-Kerezov
suggested changes
Feb 6, 2018
CONTRIBUTING.md
Outdated
| 2. Set up the project: | ||
|
|
||
| ```bash | ||
| #In the repo root |
There was a problem hiding this comment.
I'd prefer a white space after # so that it becomes
# In the repo root
README.md
Outdated
|
|
||
| When the plugin installed what it will do out of the box is to add | ||
| - `tsconfig.json` file to the project (if it doesn't exist), | ||
| - `typescript` as dependency |
There was a problem hiding this comment.
typescript will actually be a dev-dependency
|
@Mitko-Kerezov Comments are addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.