Skip to content

Plugin overwrites migrated tsconfig.json on npm install #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
otaran opened this issue May 16, 2017 · 0 comments · Fixed by #33
Closed

Plugin overwrites migrated tsconfig.json on npm install #32

otaran opened this issue May 16, 2017 · 0 comments · Fixed by #33
Labels
bug

Comments

@otaran
Copy link

otaran commented May 16, 2017

Steps to reproduce

  1. Download and unpack tns-tsconfig-migration.zip
  2. tns-tsconfig-migration/tsconfig.json contains three items in compilerOptions.paths.*:
    • ./app/tns_modules/*
    • ./node_modules/tns-core-modules/*
    • ./node_modules/*
  3. Run npm install

Expected result

tsconfig.json is not modified.

Actual result

compilerOptions.paths.* gets overwritten with the default value of two items:

  • ./node_modules/tns-core-modules/*
  • ./node_modules/*

Impact

This discards any customizations made for an app and breaks automated builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(postinstall): upgrader respects existing tsconfig paths NativeScript/nativescript-dev-typescript
2 participants
@otaran @sis0k0