Remove scss files from complied sources #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! @toddanglin this will help 👍 |
toddanglin
reviewed
Oct 17, 2016
| var path = filePath; | ||
| var parts = path.split('/'); | ||
| var filename = parts[parts.length - 1]; | ||
| return path.indexOf("App_Resources") === -1 && filename.indexOf("_") !== 0; |
There was a problem hiding this comment.
@manojdcoder Any reason to leave prefixed files in the app packages? filename.indexOf("_")
What's the benefit? If none, probably makes sense to remove this check and just remove all .scss files outside of the App_Resources directory.
There was a problem hiding this comment.
I'm going to assume this filter came from the converter.js file, where there is a need to explicitly filter-out SASS partials. I'll remove this one check and then merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there any specific reason, why this plugin leaves the SCSS files inside complied project. Anyways those will be useless at that point right?