Fix node-sass watcher #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently node-sass watcher is used to compile sass files when some changes occurs. The problem is when file A is imported in file B. If some change occurs in file A, file A will be successfully compiled by `node-sass` but file B will not be updated. So when `livesync command` is executed, changes are not reflected in the app's UI. This PR removes `--watch` option from `node-sass` compiler and introduces chokidar watcher. Also fixes this #70
rosen-vladimirov
suggested changes
Mar 22, 2018
src/lib/converter.js
Outdated
| options = options || {}; | ||
| var sassPath = getSassPath(); | ||
| var data = { | ||
| sassPath: sassPath, |
There was a problem hiding this comment.
you can use short syntax for all properties:
var data = {
sassPath,
projectDir,
...
}
src/lib/converter.js
Outdated
| cwd: appDir, | ||
| awaitWriteFinish: { | ||
| pollInterval: 100, | ||
| stabilityThreshold: 500 |
There was a problem hiding this comment.
isn't it way too long, maybe 300 ?
src/lib/converter.js
Outdated
| logger.info('Found peer node-sass'); | ||
| } catch (err) { } | ||
| } else { | ||
| throw Error('node-sass installation local to project was not found. Install by executing `npm install node-sass`.'); |
src/lib/converter.js
Outdated
| var currentSassProcess = spawn(process.execPath, nodeArgs, { env: env }); | ||
|
|
||
| var isResolved = false; | ||
| var watchResolveTimeout; |
There was a problem hiding this comment.
this variable is not used
src/lib/converter.js
Outdated
| if (code === 0) { | ||
| resolve(); | ||
| } else { | ||
| reject(Error('SASS compiler failed with exit code ' + code)); |
src/lib/converter.js
Outdated
| }); | ||
|
|
||
| // SASS does not recompile on watch, so directly resolve. | ||
| if (options.watch && !isResolved) { |
There was a problem hiding this comment.
I don't think you need the check for options.watch here
There was a problem hiding this comment.
In fact the whole if and the call to resolve is not needed here.
src/lib/converter.js
Outdated
|
|
||
| watcher = choki.watch(['**/*.scss', '**/*.sass'], watcherOptions) | ||
| .on('all', (event, filePath) => { | ||
| spawnNodeSass(data); |
There was a problem hiding this comment.
In case you apply several changes and save them one-by-one, you'll receive multiple events and several processes will be spawned. This is a problem, so I suggest chaining the calls to spawnNodeSass:
var watchPromisesChain = Promise.resolve();
watcher = choki.watch(['**/*.scss', '**/*.sass'], watcherOptions)
.on('all', (event, filePath) => {
watchPromiseChain = watchPromiseChain.then( () => spawnNodeSass(data) );
});
rosen-vladimirov
approved these changes
Mar 26, 2018
src/lib/converter.js
Outdated
| if (fs.existsSync(sassPath)) { | ||
| try { | ||
| logger.info('Found peer node-sass'); | ||
| } catch (err) { } |
There was a problem hiding this comment.
When will the logger.info fail ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently node-sass watcher is used to compile sass files when some changes occurs. The problem is when file A is imported in file B. If some change occurs in file A, file A will be successfully compiled by
node-sassbut file B will not be updated. So whenlivesync commandis executed, changes are not reflected in the app's UI.This PR removes
--watchoption fromnode-sasscompiler and introduces chokidar watcher.Also fixes this #70