Skip to content

refactor(image-comparison): calculate properly rectangle for iOS #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 1, 2017
Merged

refactor(image-comparison): calculate properly rectangle for iOS #73

merged 2 commits into from
Dec 1, 2017

Conversation

vchimev
Copy link
Contributor

@vchimev vchimev commented Nov 30, 2017

No description provided.

SvetoslavTsenov
SvetoslavTsenov reviewed Dec 1, 2017
View reviewed changes
Copy link
Contributor

@SvetoslavTsenov SvetoslavTsenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need two types of rectangles
actual one that has the real values on the screen
and one that returns values of snapshot image from device

@vchimev vchimev merged commit 91715d1 into master Dec 1, 2017
@vchimev vchimev deleted the vchimev-img branch December 1, 2017 09:21
@lock
Copy link

lock bot commented Aug 26, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SvetoslavTsenov SvetoslavTsenov SvetoslavTsenov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vchimev @SvetoslavTsenov