Skip to content

Fixed typo on string #57 #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fixed typo on string #57 #11

wants to merge 2 commits into from

Conversation

kant
Copy link
Contributor

@kant kant commented Mar 30, 2019

PR Checklist

What is the current behavior?

Fixed typo on string #57

What is the new behavior?

Fixed typo on string #57
Fixes/Implements/Closes #[Issue Number].
This PR do no close any former issue. Just fix a typo.

This PR do not break any code.

@ghost ghost added the new PR label Mar 30, 2019
@cla-bot cla-bot bot added the cla: yes label Mar 30, 2019
@ghost ghost assigned VladimirAmiorkov Apr 3, 2019
@VladimirAmiorkov
Copy link

Hi @kant ,

Thank you for your contribution.

In the future have in mind that using #(number) is source code commits relates the commit with the an issue of that number so avoid using that if the commit is not related to that specific issue. In this PR you are using #57 as a "row number" but in reality it will eventually relate the commit with an issue with number 57. We are going to handle this with a squash merge when the PR is ready for merge after its CI is cleared.

@tgpetrov
Copy link
Contributor

tgpetrov commented Apr 8, 2019

Hi @kant
Since our CI checks can't be run on forked repository, I made a new PR with your commit, which is now merged.
Thank you for your contribution.

@tgpetrov tgpetrov closed this Apr 8, 2019
@ghost ghost removed the new PR label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants