Skip to content

Fix check for Gradle version #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

rosen-vladimirov
Copy link
Contributor

In case Gradle's version is with three numbers ("2.2.3" for example), our
current check is failing and makes the doctor command unusable. Compare
current gradle version with min required one only after they are in the
same format.

Fixes #989

@rosen-vladimirov rosen-vladimirov added this to the 1.4.0 milestone Sep 30, 2015
@rosen-vladimirov rosen-vladimirov self-assigned this Sep 30, 2015
@ns-bot
Copy link

ns-bot commented Sep 30, 2015

Test FAILed.

@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-gradle-check branch from 9a94fa3 to d3707fe Compare September 30, 2015 14:00
@ns-bot
Copy link

ns-bot commented Sep 30, 2015

Test PASSed.

@Fatme
Copy link
Contributor

Fatme commented Oct 1, 2015

👍

1 similar comment
@ligaz
Copy link

ligaz commented Oct 1, 2015

👍

In case Gradle's version is with three numbers ("2.2.3" for example), our
current check is failing and makes the doctor command unusable. Compare
current gradle version with min required one only after they are in the
same format.
@rosen-vladimirov rosen-vladimirov force-pushed the vladimirov/fix-gradle-check branch from d3707fe to fc1fd13 Compare October 1, 2015 06:17
@ns-bot
Copy link

ns-bot commented Oct 1, 2015

Test PASSed.

rosen-vladimirov added a commit that referenced this pull request Oct 1, 2015
@rosen-vladimirov rosen-vladimirov merged commit f04345c into release Oct 1, 2015
@rosen-vladimirov rosen-vladimirov deleted the vladimirov/fix-gradle-check branch October 1, 2015 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants