Ability to specify android debug ui not only on OSX #972
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| @@ -170,12 +170,12 @@ class AndroidDebugService implements IDebugService { | |||
| } | |||
|
|
|||
| private openDebuggerClient(url: string): void { | |||
| let chrome = this.$hostInfo.isDarwin ? this.$config.ANDROID_DEBUG_UI_MAC : "chrome"; | |||
| let child = this.$opener.open(url, chrome); | |||
| let defaultDebugUI = this.$hostInfo.isDarwin ? "Google Chrome" : "chrome"; | |||
There was a problem hiding this comment.
some tabs issues here
|
👍 |
Fatme
force-pushed
the
fatme/android-debug-ui
branch
from
a32bab4 to
49a9003
Compare
|
Test PASSed. |
Fatme
pushed a commit
that referenced
this pull request
Sep 28, 2015
Ability to specify android debug ui not only on OSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #923