Add checks for all cached packages #964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| this.$fs.enumerateFilesInDirectorySync(path.join(packagePath, "framework")).length > 1; | ||
| (!additionalDirectoryToCheck || | ||
| (this.$fs.exists(path.join(packagePath, additionalDirectoryToCheck)).wait() && | ||
| this.$fs.enumerateFilesInDirectorySync(path.join(packagePath, additionalDirectoryToCheck)).length > 1 |
NPM Cache gets broken in some cases. Make sure to validate the sahsum of the cached package. Also validate specific directories in our `tns` related packages from npm, for example tns runtimes must have "framework" directory in the root of the unpacked dir. Fixes NativeScript/NativeScript#763
rosen-vladimirov
force-pushed
the
vladimirov/always-check-cached-package
branch
from
52297de to
ef1048b
Compare
|
Test PASSed. |
|
👍 |
rosen-vladimirov
added a commit
that referenced
this pull request
Sep 28, 2015
…hed-package Add checks for all cached packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NPM Cache gets broken in some cases. Make sure to validate the sahsum of the cached package. Also validate specific directories in our
tnsrelated packages from npm, for example tns runtimes must have "framework" directory in the root of the unpacked dir.Fixes NativeScript/NativeScript#763