Skip to content

Don't prepare platform N times if N files have been changed. #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2015
Merged

Don't prepare platform N times if N files have been changed. #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6514e77
Don't prepare platform N times if N files have been changed.
hdeshev Sep 14, 2015
55a4962
Update lib/common submodule
hdeshev Sep 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/common
Open in desktop
Submodule common updated 1 files
+5 −0 services/usb-livesync-service-base.ts
4 changes: 3 additions & 1 deletion lib/services/usb-livesync-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncSer

let beforeBatchLiveSyncAction = (filePath: string): IFuture<string> => {
return (() => {
this.$platformService.preparePlatform(platform).wait();
let projectFileInfo = this.getProjectFileInfo(filePath);
return path.join(projectFilesPath, path.relative(path.join(this.$projectData.projectDir, constants.APP_FOLDER_NAME), projectFileInfo.onDeviceName));
}).future<string>()();
Expand Down Expand Up @@ -113,6 +112,9 @@ export class UsbLiveSyncService extends usbLivesyncServiceBaseLib.UsbLiveSyncSer
}).future<void>()();
}

protected preparePlatformForSync(platform: string) {
this.$platformService.preparePlatform(platform).wait();
}
private resolveUsbLiveSyncService(platform: string, device: Mobile.IDevice): IPlatformSpecificUsbLiveSyncService {
let platformSpecificUsbLiveSyncService: IPlatformSpecificUsbLiveSyncService = null;
if(platform.toLowerCase() === "android") {
Expand Down