Support xcconfig file from plugin - close #883 #910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasssonpet
force-pushed
the
jasssonpet/xcconfig-files
branch
2 times, most recently
from
f1dd79e to
dbcb5b0
Compare
| @@ -575,6 +604,10 @@ export class IOSProjectService extends projectServiceBaseLib.PlatformProjectServ | |||
| let modulemap = `module ${libraryName} { explicit module ${libraryName} { ${headers.join(" ")} } }`; | |||
| this.$fs.writeFile(path.join(headersFolderPath, "module.modulemap"), modulemap).wait(); | |||
| } | |||
|
|
|||
| private buildXcconfigContent(xcconfigFilePath: string, xcconfigFileContent: string): string { | |||
| return `${os.EOL}// Begin xcconfig - ${xcconfigFilePath} ${os.EOL} ${xcconfigFileContent} ${os.EOL} // End xcconfig ${os.EOL}`; | |||
There was a problem hiding this comment.
I'll change this to #include directive instead of copy-paste.
jasssonpet
force-pushed
the
jasssonpet/xcconfig-files
branch
2 times, most recently
from
d8a2234 to
3844b50
Compare
jasssonpet
force-pushed
the
jasssonpet/xcconfig-files
branch
from
3844b50 to
86fd968
Compare
|
✅ |
|
ping @Fatme I think that this PR is ready to be merged. |
| let pluginXcconfigFilePath = path.join(pluginPlatformsFolderPath, "build.xcconfig"); | ||
| if(this.$fs.exists(pluginXcconfigFilePath).wait()) { | ||
| let contentToWrite = this.buildXcconfigContent(pluginXcconfigFilePath); | ||
| this.$fs.appendFile(this.projectXcconfigFilePath, contentToWrite).wait(); |
There was a problem hiding this comment.
Can we import the file instead append?
There was a problem hiding this comment.
We append an #include "pluginFileXcconfig", is that what you mean?
|
👍 |
jasssonpet
added a commit
that referenced
this pull request
Sep 15, 2015
Support xcconfig file from plugin - close #883
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the xcconfig to the project template, so that building from the Xcode project is the same as from the CLI: NativeScript/ios-jsc#302
If the added plugin has a
build.xcconfigfile inplatforms/ios, an include directive gets appended to thebuild.xcconfigin the project template.Example (incomplete) Facebook plugin:
FBSDKCoreKit is a static framework and has a dependency to CoreGraphics. So we add it In the build.xcconfig:
OTHER_LDFLAGS = $(inherited) -framework CoreGraphics.Ping @fealebenpae