Configure tns-core-modules version when init command is executed #890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| @@ -56,6 +57,12 @@ export class InitService implements IInitService { | |||
| }); | |||
| } | |||
|
|
|||
| let dependencies = projectData["dependencies"]; | |||
| if(!dependencies) { | |||
| projectData["dependencies"] = Object.create(null); | |||
There was a problem hiding this comment.
Perhaps projectData.dependencies = {}? You can use {} here, because we just serialize the object immediately.
|
👍 but you may consider using the simplified syntax I proposed. |
Fatme
force-pushed
the
fatme/conf-modules-version
branch
from
145c9e3 to
d9d6322
Compare
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Sep 8, 2015
Configure tns-core-modules version when init command is executed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #875