Add warning that library add command will be removed in a future release #889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -7,21 +7,23 @@ General | `$ tns library add <Platform> <Library Path>` | |||
|
|
|||
| Adds a locally stored native library to the current project. <% if(isHtml) { %>Copies the library files to the `lib/<platform>` folder in your project and configures the platform-specific projects in `platforms/<platform>` to work with the library. Build operations might perform additional configuration changes on the platform-specific project in `platforms/<platform>`.<% } %> | |||
|
|
|||
| IMPORTANT: The `tns library add` command is deprecated and will be removed in a future release. Use the plugin set of commands instead. For more information, run `tns help plugin`. | |||
There was a problem hiding this comment.
Here, we can make this more user-friendly. For the "for more information part", use context.
For more information, <% if(isHtml) { %>see the [plugin](plugin.html) set of commands.<% } %><% if(isConsole) { %>run `tns help plugin`.<% } %>
There was a problem hiding this comment.
Also, it seems that we're probably deprecating the entire library set of commands. Shouldn't we apply this message to the library command as well? If we decide to do this Make the message "The tns library set of commands is deprecated and..."
There was a problem hiding this comment.
And make this "Use the tns plugin set of commands."
|
✅ |
Fatme
force-pushed
the
fatme/warning-for-add-library
branch
from
9fc3e6b to
15b5fbb
Compare
|
✅ |
| @@ -7,11 +7,13 @@ General | `$ tns library <Command>` | |||
|
|
|||
| Lets you manage third-party native libraries in your project. You must run the `library` command with a command extension. | |||
|
|
|||
| IMPORTANT: The `tns library` set of commands are deprecated and will be removed in a future release. Use the `tns plugin` set of commands instead. For more information, <% if(isHtml) { %>see the [plugin](plugin.html) set of commands.<% } %><% if(isConsole) { %>run `tns help plugin`.<% } %>. | |||
There was a problem hiding this comment.
Hmmm, make this "The tns library command is deprecated" perhaps - sorry about that.
Fatme
force-pushed
the
fatme/warning-for-add-library
branch
from
15b5fbb to
c2c6ce6
Compare
|
✅ |
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Sep 8, 2015
Add warning that library add command will be removed in a future release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.