Update correctly ant template to gradle #886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| @@ -153,11 +153,21 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService | |||
| } | |||
|
|
|||
| public canUpdatePlatform(currentVersion: string, newVersion: string): IFuture<boolean> { | |||
| return Future.fromResult<boolean>(true); | |||
| return (() => { | |||
There was a problem hiding this comment.
perhaps return Future.fromResult(true)?
Fatme
force-pushed
the
fatme/fix-platform-update-from-ant-template
branch
from
e5e79f4 to
69a5c05
Compare
| this.$fs.deleteDirectory(destinationFile).wait(); | ||
| shell.cp("-R", path.join(sourceFile, "*"), destinationFile); | ||
| this.$logger.info("Backup file %s at location %s", sourceFile, destinationFile); | ||
| this.$fs.deleteDirectory(path.join(this.platformData.projectRoot, util.format("%s.xcodeproj", this.$projectData.projectName))).wait(); |
There was a problem hiding this comment.
Isn't this deleteDirectory(sourceFile)?
|
✅ |
1 similar comment
|
✅ |
Fatme
force-pushed
the
fatme/fix-platform-update-from-ant-template
branch
from
0a05e6e to
39d6874
Compare
|
✅ |
Fatme
force-pushed
the
fatme/fix-platform-update-from-ant-template
branch
from
39d6874 to
f3f7ea3
Compare
|
Squash and go, 👍 |
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Sep 8, 2015
…rom-ant-template Update correctly ant template to gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.