Skip to content

Support static libraries in plugins for iOS. #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2015
Merged

Support static libraries in plugins for iOS. #885

merged 2 commits into from
Sep 10, 2015

Conversation

e2l3n
Copy link
Contributor

@e2l3n e2l3n commented Sep 7, 2015

Implement ability to use static libraries in iOS projects.
Implement unit tests.
Addresses issue #686

@ns-bot
Copy link

ns-bot commented Sep 7, 2015

Can one of the admins verify this patch?

@e2l3n e2l3n force-pushed the tpopov/static-libs branch 2 times, most recently from 26dac8d to 43e7ac0 Compare September 7, 2015 19:19
@e2l3n e2l3n added feature and removed feature labels Sep 8, 2015
Fatme
Fatme reviewed Sep 8, 2015
View reviewed changes
lib/services/ios-project-service.ts
if (extension === ".framework") {
this.addDynamicFramework(libraryPath);
} else {
this.$errors.failWithoutHelp("The bundle at %s does not appear to be a dynamic framework package.", libraryPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use template strings.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider explaining the user how to fix the issue - i.e. - can they use another command?

@e2l3n e2l3n force-pushed the tpopov/static-libs branch from 43e7ac0 to b8129a9 Compare September 8, 2015 09:08
teobugslayer
teobugslayer reviewed Sep 8, 2015
View reviewed changes
lib/definitions/xcode.d.ts
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why does this empty space not trigger the linter? At any rate, please remove it.

@teobugslayer
Copy link
Contributor 

>> lib/services/ios-project-service.ts[200, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[211, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[215, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[239, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[242, 53]: trailing whitespace
>> lib/services/ios-project-service.ts[249, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[254, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[257, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[367, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[377, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[420, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[438, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[444, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[445, 61]: trailing whitespace
>> lib/services/ios-project-service.ts[447, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[448, 43]: trailing whitespace
>> lib/services/ios-project-service.ts[483, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[493, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[521, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[525, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[529, 52]: trailing whitespace
>> lib/services/ios-project-service.ts[530, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[560, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[565, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[570, 1]: trailing whitespace
>> lib/services/ios-project-service.ts[574, 1]: trailing whitespace
>> test/ios-project-service.ts[172, 1]: trailing whitespace
>> test/ios-project-service.ts[180, 1]: trailing whitespace
>> test/ios-project-service.ts[184, 1]: trailing whitespace
>> test/ios-project-service.ts[191, 1]: trailing whitespace
>> test/ios-project-service.ts[198, 1]: trailing whitespace
>> test/ios-project-service.ts[201, 1]: trailing whitespace
>> test/ios-project-service.ts[219, 29]: trailing whitespace
>> test/ios-project-service.ts[220, 1]: trailing whitespace
>> test/ios-project-service.ts[224, 1]: trailing whitespace
>> test/ios-project-service.ts[222, 8]: unused variable: 'fs'

@teobugslayer teobugslayer added this to the 1.4.0 milestone Sep 8, 2015
teobugslayer
teobugslayer reviewed Sep 9, 2015
View reviewed changes
lib/services/ios-project-service.ts

this.generateMobulemap(path.join(libDestinationPath, headersSubpath), libraryName);
this.savePbxProj(project).wait();
}).future<void>()();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tab issues?

@e2l3n e2l3n force-pushed the tpopov/static-libs branch 2 times, most recently from 8727b13 to 07356fd Compare September 10, 2015 10:57
@e2l3n e2l3n force-pushed the tpopov/static-libs branch from 07356fd to 9abff15 Compare September 10, 2015 11:18
@e2l3n
Copy link
Contributor Author

e2l3n commented Sep 10, 2015

Rebase current branch onto master.

@e2l3n e2l3n force-pushed the tpopov/static-libs branch 3 times, most recently from ec6a37e to e9c8d01 Compare September 10, 2015 11:50
@teobugslayer
Copy link
Contributor

👍

@dtopuzov
Copy link
Contributor

run ci

@e2l3n e2l3n force-pushed the tpopov/static-libs branch from e9c8d01 to 43b1ec2 Compare September 10, 2015 12:44
@dtopuzov dtopuzov closed this Sep 10, 2015
@dtopuzov dtopuzov reopened this Sep 10, 2015
@e2l3n e2l3n force-pushed the tpopov/static-libs branch from 43b1ec2 to 81be681 Compare September 10, 2015 12:57
@ns-bot
Copy link

ns-bot commented Sep 10, 2015

❌

@ns-bot
Copy link

ns-bot commented Sep 10, 2015

✅

e2l3n added a commit that referenced this pull request Sep 10, 2015
@e2l3n
Merge pull request #885 from NativeScript/tpopov/static-libs
e50c9b4 
Support static libraries in plugins for iOS.
@e2l3n e2l3n merged commit e50c9b4 into master Sep 10, 2015
@teobugslayer teobugslayer deleted the tpopov/static-libs branch October 2, 2015 09:05
@e2l3n e2l3n mentioned this pull request Oct 7, 2015
Merged
@e2l3n e2l3n mentioned this pull request Dec 9, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@e2l3n @ns-bot @teobugslayer @dtopuzov @Fatme @ikoevska