Guard against errors in npm #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teobugslayer
force-pushed
the
totev/guard-npm-assert
branch
from
97f6be6 to
3a76740
Compare
|
✅ |
|
👍 after green build |
|
✅ |
teobugslayer
added a commit
that referenced
this pull request
Aug 26, 2015
Guard against errors in npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #819
Note: npm actually
asserttheir parameters instead of calling the provided callback with an error.In our code, this means that an exception is being thrown in async code which was running without being guarded in a fiber. The end result is process tear down without any chance for us to intervene.
We need to file a issue to npm to fix their code to call the callback with an error in this case.