Skip to content

Gradle support #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 27, 2015
Merged

Gradle support #817

merged 1 commit into from
Aug 27, 2015

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Aug 25, 2015

@Fatme Fatme added this to the 1.3.0 milestone Aug 25, 2015
@ns-bot
Copy link

ns-bot commented Aug 25, 2015

✅

teobugslayer
teobugslayer reviewed Aug 25, 2015
View reviewed changes
lib/services/android-project-service.ts
@@ -436,23 +381,11 @@ class AndroidProjectService extends projectServiceBaseLib.PlatformProjectService
return newTarget;
}).future<string>()();
}

private updateTarget(projectRoot: string, newTarget: string): IFuture<void> {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded empty space

@teobugslayer
Copy link
Contributor

Can we link to the GitHub issue we are addressing?

@dtopuzov
Copy link
Contributor

👍

@Fatme Fatme force-pushed the fatme/gradle-support branch 3 times, most recently from 73d6653 to 8cb098b Compare August 26, 2015 07:50
teobugslayer
teobugslayer reviewed Aug 26, 2015
View reviewed changes
lib/services/android-project-service.ts
return (() => {
this.$projectDataService.initialize(this.$projectData.projectDir);
let frameworkVersion = this.$projectDataService.getValue(this.platformData.frameworkPackageName).wait().version;
if(semver.lt(frameworkVersion, "1.3.0")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.3.0 is a magic constant - consider naming it

@Fatme Fatme force-pushed the fatme/gradle-support branch from 8cb098b to 0be18e4 Compare August 27, 2015 07:18
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

❌

@Fatme Fatme force-pushed the fatme/gradle-support branch 4 times, most recently from ac8e980 to ed3deae Compare August 27, 2015 08:42
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@teobugslayer
Copy link
Contributor

Linter messages:

>> lib/services/android-project-service.ts[76, 1]: trailing whitespace
>> lib/services/android-project-service.ts[79, 12]: trailing whitespace
>> lib/services/android-project-service.ts[262, 1]: trailing whitespace
>> lib/services/android-project-service.ts[415, 1]: trailing whitespace
>> lib/services/doctor-service.ts[73, 3]: if statements must be braced
>> lib/services/doctor-service.ts[74, 1]: trailing whitespace

@Fatme
Copy link
Contributor Author

Fatme commented Aug 27, 2015

I fixed all lint messages. Just get the latest changes.

@Fatme Fatme force-pushed the fatme/gradle-support branch from ed3deae to 4b54320 Compare August 27, 2015 09:03
@teobugslayer
Copy link
Contributor

👍

@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from 4b54320 to b2bc5d7 Compare August 27, 2015 09:35
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

❌

@Fatme Fatme force-pushed the fatme/gradle-support branch from b2bc5d7 to 61f01d8 Compare August 27, 2015 09:39
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from 61f01d8 to b64baf3 Compare August 27, 2015 09:53
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from b64baf3 to e65ef2e Compare August 27, 2015 11:57
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from e65ef2e to d2214b0 Compare August 27, 2015 13:11
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from d2214b0 to 9cc074a Compare August 27, 2015 13:15
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme force-pushed the fatme/gradle-support branch from 9cc074a to be97629 Compare August 27, 2015 13:18
@ns-bot
Copy link

ns-bot commented Aug 27, 2015

✅

@Fatme Fatme added the feature label Aug 27, 2015
Fatme pushed a commit that referenced this pull request Aug 27, 2015
Merge pull request #817 from NativeScript/fatme/gradle-support
752112c 
Gradle support
@Fatme Fatme merged commit 752112c into master Aug 27, 2015
@Fatme Fatme deleted the fatme/gradle-support branch August 27, 2015 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Fatme @ns-bot @teobugslayer @dtopuzov