Help command #8
Closed
Help command #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename bin/nativescript.cmd to tns.cmd * Fix tns --version command * Add appid option * Use com.telerik.<App name> as default application identifier * Add help for --copy-from option * Remove setLoggerConfiguration * Add config.client * Fix the check for "source app/ is not a direct ancestor of a target app/" * We don't need ensureProject, we can throw the error when projectData is initializing. ;) * Fix message outputed from platform command * isPlatformInstalled validation for prepare and build commands
| @@ -65,7 +63,7 @@ export class PlatformService implements IPlatformService { | |||
| return(() => { | |||
| platform = platform.split("@")[0]; | |||
|
|
|||
| this.validatePlatform(platform); | |||
| this.validatePlatform(platform, true); | |||
There was a problem hiding this comment.
Avoid boolean method arguments - it's impossible to tell what this switch does without going to the method definition.
http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html
Maybe a second overload will work best here validatePlatform(platform) and validatePlatformInstalled(platform)
|
Should be rebased on master. |
|
I prefer to cherry pick the commits. It seems that it'll be easier :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some improvements and fixes in this PR to ensure that all commands and options described in
help.txtare working properly.