Skip to content

Remove plugin platforms folder #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 30, 2015
Merged

Conversation

Fatme
Copy link
Contributor

@Fatme Fatme commented Jul 29, 2015

Should be merged after this PR NativeScript/node-xcode#4

If the platform is added before the plugin, the plugin platforms directory inside tns_modules is not deleted. This way the native libraries are copied twice in project - in lib folder and tns_modules folder, which increases the package size of an application a lot.

@Fatme Fatme added the bug label Jul 29, 2015
@Fatme Fatme added this to the 1.2.2 milestone Jul 29, 2015
@ns-bot
Copy link

ns-bot commented Jul 29, 2015

@rosen-vladimirov
Copy link
Contributor

👍

Fatme pushed a commit that referenced this pull request Jul 30, 2015
…ms-folder

Remove plugin platforms folder
@Fatme Fatme merged commit 36b7d5d into release Jul 30, 2015
@Fatme Fatme deleted the fatme/remove-plugin-platforms-folder branch July 30, 2015 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants