Open correct debugger url when framework version is lower than 1.2.0 #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -238,7 +239,7 @@ class IOSDebugService implements IDebugService { | |||
| tnsIosPackage = path.resolve(this.$options.frameworkPath); | |||
| } else { | |||
| var platformData = this.$platformsData.getPlatformData(this.platform); | |||
| tnsIosPackage = this.$npmInstallationManager.install(platformData.frameworkPackageName).wait(); | |||
| tnsIosPackage = this.$npmInstallationManager.getCachedPackagePath(platformData.frameworkPackageName, frameworkVersion); | |||
There was a problem hiding this comment.
if the cache had been cleaned, will this add the dependency with its correct version to the cache?
|
✅ |
Fatme
force-pushed
the
fatme/open-correct-debugger-url
branch
from
592860b to
c797510
Compare
|
✅ |
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Jul 29, 2015
…-url Open correct debugger url when framework version is lower than 1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
#652 and #671