Add library with relative path to .xcodeproj file #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
|
|
||
| let project = this.createPbxProj(); | ||
|
|
||
| project.addFramework(path.join(targetPath, frameworkName + ".framework"), { customFramework: true, embed: true }); | ||
| let frameworkPath = path.relative("platforms/ios", path.join(targetPath, frameworkName + ".framework")); |
There was a problem hiding this comment.
platforms/ios - will this work on Windows?
Maybe:
let frameworkPath = path.relative(path.join("platforms", "ios"), path.join(targetPath, frameworkName + ".framework"));There was a problem hiding this comment.
Also, don't you need full paths on both places:
let frameworkPath = path.relative(path.join(this.$projectData.projectDir, "platforms", "ios"), path.join(fullTargetPath, frameworkName + ".framework"));There was a problem hiding this comment.
"platforms/ios - will this work on Windows?" - This service is executed only on OSX.
"Also, don't you need full paths on both places:" - No, I don't need the fullPath, a just need the relative path to native project.
There was a problem hiding this comment.
By the way, it works - but path.join will return a string with backslashes.
|
👍 |
Fatme
pushed a commit
that referenced
this pull request
Jul 28, 2015
…tive-path Add library with relative path to .xcodeproj file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #679