Fix ios debugger for projects created with framework version lower than 1.2.0… #668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ |
| let frameworkVersion = this.$projectDataService.getValue(platformData.frameworkPackageName).wait().version; | ||
| if(semver.lt(frameworkVersion, "1.2.0")) { | ||
| let safariPath = path.join(inspectorPath, "Safari/Main.html"); | ||
| cmd = "open -a Safari " + safariPath; |
There was a problem hiding this comment.
is it possible safariPath to have spaces in it? Should we escape it?
There was a problem hiding this comment.
It is possible only when the user changes the default npm cache path 😸 I'll escape it.
Fatme
force-pushed
the
fatme/fix-ios-debugger
branch
from
bf8f7cc to
dc63f5f
Compare
|
❌ |
Fatme
force-pushed
the
fatme/fix-ios-debugger
branch
from
dc63f5f to
ebba4ca
Compare
|
👍 |
|
run ci |
|
✅ |
Fatme
force-pushed
the
fatme/fix-ios-debugger
branch
from
ebba4ca to
c9afb9f
Compare
|
✅ |
Fatme
pushed a commit
that referenced
this pull request
Jul 22, 2015
Fix ios debugger for projects created with framework version lower than 1.2.0…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the project is created with framework version lower than 1.2,
tns debug ioscommand fails with the following error: "Command failed: /bin/sh -c open -a '/.npm/tns-ios/1.1.2/package/WebInspectorUI/NativeScript Inspector.app' --args '/.npm/tns-ios/1.1.2/package/WebInspectorUI/Safari/Main.html' 'newAppRelease'FSPathMakeRef(~/.npm/tns-ios/1.1.2/package/WebInspectorUI/NativeScript Inspector.app) failed with error -43."